[PATCH] mergetool: Make ECMerge use the settings as specified by the user in the GUI

Subsystems: the rest

STALE3706d

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] mergetool: Make ECMerge use the settings as specified by the user in the GUI

From: Sebastian Schuberth <hidden>
Date: 2016-06-15 22:44:34

When run from the command line, ECMerge does not automatically use the same
settings for a merge / diff that it would use when starting the GUI and loading
files manually. In the first case the built-in factory defaults would be used,
while in the second case the settings the user has specified in the GUI would
be used, which can be misleading. Specifying the "--default" command line
option changes this behavior so that always the user specfified GUI settings
are used.

Signed-off-by: Sebastian Schuberth <redacted>
---
 git-mergetool.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-mergetool.sh b/git-mergetool.sh
index 5c86f69..fcdec4a 100755
--- a/git-mergetool.sh
+++ b/git-mergetool.sh
@@ -237,9 +237,9 @@ merge_file () {
 	ecmerge)
 	    touch "$BACKUP"
 	    if base_present; then
-		"$merge_tool_path" "$BASE" "$LOCAL" "$REMOTE" --mode=merge3 --to="$MERGED"
+		"$merge_tool_path" "$BASE" "$LOCAL" "$REMOTE" --default --mode=merge3 --to="$MERGED"
 	    else
-		"$merge_tool_path" "$LOCAL" "$REMOTE" --mode=merge2 --to="$MERGED"
+		"$merge_tool_path" "$LOCAL" "$REMOTE" --default --mode=merge2 --to="$MERGED"
 	    fi
 	    check_unchanged
 	    ;;
-- 
1.5.5.GIT

Re: [PATCH] mergetool: Make ECMerge use the settings as specified by the user in the GUI

From: Sebastian Schuberth <hidden>
Date: 2016-06-15 22:44:34

be used, which can be misleading. Specifying the "--default" command line
option changes this behavior so that always the user specfified GUI settings
are used.

Signed-off-by: Sebastian Schuberth <redacted>
Sorry, I just saw the typo, of course this should say "[...] user specified GUI settings [...]". And the subject has two spaces between "[...] by  the [...]", which should be only one.

-- 
Sebastian Schuberth

Re: [PATCH] mergetool: Make ECMerge use the settings as specified by the user in the GUI

From: Steffen Prohaska <hidden>
Date: 2016-06-15 22:44:35

On May 6, 2008, at 12:53 PM, Sebastian Schuberth wrote:
When run from the command line, ECMerge does not automatically use  
the same
settings for a merge / diff that it would use when starting the GUI  
and loading
files manually. In the first case the built-in factory defaults  
would be used,
while in the second case the settings the user has specified in the  
GUI would
be used, which can be misleading. Specifying the "--default" command  
line
option changes this behavior so that always the user specfified GUI  
settings
are used.

I tested the change and propose to take the patch.  I needed,
however, to remove dos line endings from the patch before it
applied cleanly.

	Steffen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help