When I issue this command:
git-send-email --from Timur Tabi [off-list ref] --suppress-cc=all --to
timur@tabi.org --smtp-server remotesmtp.freescale.net
0001--PATCH-Update-CS4270-driver-to-ASoC-V2.patch
I get this output:
Skipping - not found.
0001--PATCH-Update-CS4270-driver-to-ASoC-V2.patch
OK. Log says:
Server: remotesmtp.freescale.net
MAIL FROM:[off-list ref]
RCPT TO:[off-list ref]
From: Timur Tabi <redacted>
To: timur@tabi.org
Subject: [PATCH] Update CS4270 driver to ASoC V2
Date: Mon, 28 Apr 2008 16:13:34 -0500
Message-Id: [off-list ref]
X-Mailer: git-send-email 1.5.5
Result: 250 2.0.0 m3SLDY4k005131 Message accepted for delivery
I don't know enough about Perl to debug this, but I presume the problem is in
this code:
for my $f (@ARGV) {
if (-d $f) {
opendir(DH,$f)
or die "Failed to opendir $f: $!";
push @files, grep { -f $_ } map { +$f . "/" . $_ }
sort readdir(DH);
} elsif (-f $f) {
push @files, $f;
} else {
print STDERR "Skipping $f - not found.\n";
}
}
My guess is that "$f", at some point, is an empty string or a blank space.
--
Timur Tabi
Linux kernel developer at Freescale
On Mon, Apr 28, 2008 at 04:15:24PM -0500, Timur Tabi wrote:
When I issue this command:
git-send-email --from Timur Tabi [off-list ref] --suppress-cc=all --to
timur@tabi.org --smtp-server remotesmtp.freescale.net
0001--PATCH-Update-CS4270-driver-to-ASoC-V2.patch
Surely that is not the command you issued, since it lacks shell quoting
around your name and email address.
I don't know enough about Perl to debug this, but I presume the problem is in
this code:
[...]
for my $f (@ARGV) {
[...]
print STDERR "Skipping $f - not found.\n";
Yes, that is what is producing the error message. But that is the first
time we ever look at @ARGV, let alone modify it. So the error is almost
certainly caused by a blank argument being passed on the command line.
And we can't debug that unless you show us the exact shell invocation
that was used.
-Peff
Jeff King wrote:
quoted
git-send-email --from Timur Tabi [off-list ref] --suppress-cc=all --to
timur@tabi.org --smtp-server remotesmtp.freescale.net
0001--PATCH-Update-CS4270-driver-to-ASoC-V2.patch
Surely that is not the command you issued, since it lacks shell quoting
around your name and email address.
You're right. It's the output from an "echo" command in a shell script, which
likes to remove quotation marks. I keep forgetting that it does that.
Yes, that is what is producing the error message. But that is the first
time we ever look at @ARGV, let alone modify it. So the error is almost
certainly caused by a blank argument being passed on the command line.
Right again! I did a more through check of the command-line arguments, and I am
sending '' as one argument on the command line.
I just rewrote my script so that it doesn't ever send a null argument. Thanks
for the help.
--
Timur Tabi
Linux kernel developer at Freescale