Questions on patch lifecycle

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

Questions on patch lifecycle

From: Roman V. Shaposhnik <hidden>
Date: 2016-06-15 22:44:31

I'm a bit confused by the etiquette around submitting
proposals for patches in Git and I would like to
understand this process better. Especially since the
only way to get closure on .gitconfig issue seems to
be to show the code ;-)

Anyway, here are the questions:

   0. Junio, are you the only Git maintainer or are there
      others responsible for particular subsystems of Git?
  
   1. What's the official way of submitting a patch?
      Is git-send-email(1) to this mailing list
      good enough? Does a submitter have to have
      a public tree that maintainer(s) can pull from?

   2. Once the patch is submitted how does the author
      get notified whether it is accepted, rejected
      or needs additional work.

Now, #2 is especially important for me, simply because
the project I come from (FFmpeg) has a bit of different 
policy around the status of each submitted patch. 
Pretty much within a 48 hour window a submitter gets 
notified whether the patch was accepted, rejected, needs 
more work or the maintainer of a particular subsystem needs 
more time in order to review the changes. What's confusing to 
me with Git, are the examples like some patches from Ping Yin 
not receiving any public acknowledgment at all and some of the 
patches from other submitters (Dmitry Potapov) getting sort of 
lost.

Thanks,
Roman.

Re: Questions on patch lifecycle

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:44:31

"Roman V. Shaposhnik" [off-list ref] wrote:
   0. Junio, are you the only Git maintainer or are there
      others responsible for particular subsystems of Git?
There are a number of subsystem maintainers, but most stuff
does go through Junio, yes.
   
   1. What's the official way of submitting a patch?
      Is git-send-email(1) to this mailing list
      good enough? Does a submitter have to have
      a public tree that maintainer(s) can pull from?
Docmentation/SubmittingPatches
   2. Once the patch is submitted how does the author
      get notified whether it is accepted, rejected
      or needs additional work.
Rejections get emailed to the author, and generally also to the list.

Acceptance needs to be watched for by the author by fetching Junio's
nightly updates, and seeing if your patch made it into next, or into
pu, or not at all.

If it isn't there after a couple of days and if you have also not
received a rejection notice indicating why it was not applied,
it probably got dropped.  A polite reminder would then be OK.

-- 
Shawn.

Re: Questions on patch lifecycle

From: Paolo Bonzini <hidden>
Date: 2016-06-15 22:44:31

Acceptance needs to be watched for by the author by fetching Junio's
nightly updates, and seeing if your patch made it into next, or into
pu, or not at all.
Also, if it is not, you can use the "What's cooking" messages to 
understand if it fell through the cracks of Junio's mailboxes or if he 
just had no time to look at it.

Paolo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help