Re: [PATCH] Add interactive option in rebase command completion list.

Pascal Obry [off-list ref] writes:

-		__gitcomp "--onto --merge --strategy"
+		__gitcomp "--onto --merge --strategy --interactive"

I personally do not think this is worth it where a single "-i" is enough.

On Sun, Apr 6, 2008 at 12:19 PM, Junio C Hamano [off-list ref] wrote:

Pascal Obry [off-list ref] writes:

 > -             __gitcomp "--onto --merge --strategy"
 > +             __gitcomp "--onto --merge --strategy --interactive"

 I personally do not think this is worth it where a single "-i" is enough.

One advantage of bash completion, in my opinion, is being able to be
reminded of option names by tabbing twice to get a list of possible
completions.  For exactly such a case, I'd be in favor of this patch.

Just my $0.02,
Elijah

Junio C Hamano a écrit :

Pascal Obry [off-list ref] writes:

quoted

-		__gitcomp "--onto --merge --strategy"
+		__gitcomp "--onto --merge --strategy --interactive"

I personally do not think this is worth it where a single "-i" is enough.

I like unambiguous name (I do prefer --interactive instead of -i). It is 
painful to enter so the bash completion come quite handy here. The patch 
is safe, simple and clean, I see no reason to not include it.

Pascal.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595

Pascal Obry [off-list ref] wrote:

Junio C Hamano a écrit :

quoted

Pascal Obry [off-list ref] writes:

quoted

-		__gitcomp "--onto --merge --strategy"
+		__gitcomp "--onto --merge --strategy --interactive"

I personally do not think this is worth it where a single "-i" is enough.

I like unambiguous name (I do prefer --interactive instead of -i). It is 
painful to enter so the bash completion come quite handy here. The patch 
is safe, simple and clean, I see no reason to not include it.

I agree with Pascal here, include the option.

Signed-off-by: Shawn O. Pearce <redacted>

-- 
Shawn.

"Shawn O. Pearce" [off-list ref] wrote:

Pascal Obry [off-list ref] wrote:

quoted

Junio C Hamano a écrit :

quoted

Pascal Obry [off-list ref] writes:

quoted

-		__gitcomp "--onto --merge --strategy"
+		__gitcomp "--onto --merge --strategy --interactive"

I personally do not think this is worth it where a single "-i" is enough.

I like unambiguous name (I do prefer --interactive instead of -i). It is 
painful to enter so the bash completion come quite handy here. The patch 
is safe, simple and clean, I see no reason to not include it.

I agree with Pascal here, include the option.

Signed-off-by: Shawn O. Pearce <redacted>

Gaaaah.

I didn't mean SBO. I mean Acked-by!

Stupid fingers.

-- 
Shawn.