Re: [ANNOUNCE] tig-0.10

Jonas Fonseca [off-list ref] writes:

Junio C Hamano [off-list ref] wrote Mon, Mar 17, 2008:

quoted

Jonas Fonseca [off-list ref] writes:

quoted

... Building the documentation
(sadly?) now depends on DocBook XSL 1.72 to reduce the number of
accumulated AsciiDoc and XSL hacks.

Well, I've been a quiet but big fan of tig for quite some time, but to me,
requiring autoreconf is a much larger regression than DocBook dependency.

I am not sure I understand. As far as I know, tig does not require
autoreconf unless you have cloned the repository and want to bootstrap
the configure script.

Yeah, but that was exactly what your announcement suggested to.  Show
Tarball and Gitfeed alternatives to a git person, who already has a clone
of the project, and guess which one he would go ;-).

Also INSTALL file begins with:

Installation instructions
-------------------------

Download a tarball from http://jonas.nitro.dk/tig/releases[] or clone the tig
repository http://jonas.nitro.dk/tig/tig.git[]. Documentation files are
available either in the tarballs or in the above repository in the branch named
'release'.

To install tig simply run:

        $ autoreconf
        $ ./configure
        $ make install

By the way, it would be nice if someday I can get tig work with CJK.
Perhaps I need to tweak something in ncurses?

Junio C Hamano [off-list ref] wrote Mon, Mar 17, 2008:

Jonas Fonseca [off-list ref] writes:

quoted

I am not sure I understand. As far as I know, tig does not require
autoreconf unless you have cloned the repository and want to bootstrap
the configure script.

Yeah, but that was exactly what your announcement suggested to.  Show
Tarball and Gitfeed alternatives to a git person, who already has a clone
of the project, and guess which one he would go ;-).

Also INSTALL file begins with:

[...]

Ok, I will try to make it more clear that usage of configure (and
autoreconf) is optional.

By the way, it would be nice if someday I can get tig work with CJK.
Perhaps I need to tweak something in ncurses?

I will make it a priority to fix this shortcoming. Until then you can
improve the situation by linking with the ncursesw library. At least the
diff view and names in the commit listing will be properly displayed.

diff --git a/Makefile b/Makefile
index 575c5bf..e57ae6a 100644
--- a/Makefile
+++ b/Makefile

@@ -32,7 +32,7 @@ RPM_VERLIST = $(filter-out g% dirty,$(subst -, ,$(VERSION))) 0
 RPM_VERSION = $(word 1,$(RPM_VERLIST))
 RPM_RELEASE = $(word 2,$(RPM_VERLIST))$(if $(WTDIRTY),.dirty)
 
-LDLIBS ?= -lcurses
+LDLIBS ?= -lncursesw
 CFLAGS ?= -Wall -O2
 DFLAGS	= -g -DDEBUG -Werror
 PROGS	= tig

-- 
Jonas Fonseca