Looking at this exchange really makes me suspect that these
things should not be in C. Every time Emacs updates we need
recompilation? Yuck.
In fact, I am pretty confident that emacsclient has always
printed its version onto stdout so I do not think we need to
recompile every week :)
What was the reason we gave up calling out to a single generic
scripted wrapper that the users can just munge to suit their
tastes?
Good question. Though I find chriscool's implementation nicely
thought. With the modifications I made, this works as expected
with either emacs22 and emacs23 (aka CVS). What's more, how a
user could have tested if emacsclient was provided in the right
version using a generic scripted wrapper ?
I guess, chriscool should provide a more consistent emacsclient
wrapper with support for GNU Emacs version >= 21. This won't be
an enormous amount of work to do it (I can help him if he wants
to but I do not want to steal the paternity of his idea).
Xavier
--
http://www.gnu.org
http://www.april.org
http://www.lolica.org
Le samedi 1 mars 2008, Xavier Maillard a écrit :
Looking at this exchange really makes me suspect that these
things should not be in C. Every time Emacs updates we need
recompilation? Yuck.
In fact, I am pretty confident that emacsclient has always
printed its version onto stdout so I do not think we need to
recompile every week :)
On my Kubuntu Feisty development machine with the stock emacs
21.4a+1-2ubuntu1.1 package I get:
$ emacsclient --version
emacsclient 21.4
$ emacsclient --version 2>/dev/null
$ emacsclient --version 1>/dev/null
emacsclient 21.4
And I don't think it specific to Kubuntu because I remenber getting the same
with emacs21 (before installing emacs22) on another (Debian testing)
machine.
What was the reason we gave up calling out to a single generic
scripted wrapper that the users can just munge to suit their
tastes?
I didn't gave up, I am just waiting for the implementation of a scripted
wrapper in git-mergetool.sh, that is now in 'pu', to mature. Then I will
steal it so we have the same for git help.
Good question. Though I find chriscool's implementation nicely
thought.
Thanks.
With the modifications I made, this works as expected
with either emacs22 and emacs23 (aka CVS). What's more, how a
user could have tested if emacsclient was provided in the right
version using a generic scripted wrapper ?
I agree that it's better to do it for the users.
In fact just after this email, I will send a patch to "run_command.c" named:
"Redirect stderr to a pipe before redirecting stdout to stderr"
that will make my last patches to "help.c" work with both Emacs21 and
Emacs22.
I guess, chriscool should provide a more consistent emacsclient
wrapper with support for GNU Emacs version >= 21. This won't be
an enormous amount of work to do it (I can help him if he wants
to but I do not want to steal the paternity of his idea).
It would help if you could test with Emacs23 as I didn't installed it.
Thank you for testing my patches.
Christian.