Re: [PATCH 5/9] http-push: Avoid calling setup_git_directory() twice

Nguyễn Thái Ngọc Duy [off-list ref] writes:

Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>
---
 http-push.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Calling setup more than once is now an error?  I do not mind the
new restriction but is it documented clearly somewhere?

On Thu, Feb 28, 2008 at 7:50 AM, Junio C Hamano [off-list ref] wrote:

Nguyễn Thái Ngọc Duy [off-list ref] writes:

 > Signed-off-by: Nguyễn Thái Ngọc Duy [off-list ref]
 > ---
 >  http-push.c |    4 ++--
 >  1 files changed, 2 insertions(+), 2 deletions(-)

 Calling setup more than once is now an error?  I do not mind the
 new restriction but is it documented clearly somewhere?

This part was left from my attempt to make setup_git_directory()
return no prefix. The attempt failed but I thought it was a still good
cleanup. Now think it again. I agree calling setup_git_directory()
twice is an error as it may call setup_work_tree(NULL) twice. Yes it
needs to be documented. Will amend the documentation patch.
-- 
Duy