Re: [PATCH] http-push: making HTTP push more robust and more user-friendly

Daniel Barkalow [off-list ref] writes:

On Mon, 21 Jan 2008, Junio C Hamano wrote:

quoted

Johannes Schindelin [off-list ref] writes:

quoted

IMHO it is safer to disable it for curl < 7.0xa -- even if it affects a 
number of distros -- than to give the illusion that it works, when it does 
not.

As for fixing it in the non-MULTI case, I have a hunch that Mike's 
cleanups will help that, but that this is a 1.5.5 feature.

So, I would like to read in the ReleaseNotes something like this:

-- snip --
Support for pushing via HTTP was broken with curl versions prior to 7.16, 
so we disabled it for now.  However, it is likely that a major cleanup of 
the http transport code -- scheduled after the release of git 1.5.4 -- 
will be supported with more curl versions.
-- snap --

That's tempting but I suspect that it might be a wrong approach.

I think two important questions are:

 * Do we know that the current code is broken for everybody, or
   just broken for the majority of people who do nontrivial
   things?

 * Is the code in 1.5.3.8 any better?  IOW, did we make it worse
   during 1.5.4 cycle?

I believe that the move to transport.c didn't change anything except 
cleaning up linking conflicts and moving the dispatch by URL method code. 
I suppose something could have gotten messed up in dealing with the 
linking conflicts, but I don't think it actually did.

Ok, so copying 1.5.3.8 http-push to include in 1.5.4 would not
make it work, it sounds like.  Then I guess Dscho's notice (and
the same notice with disabling http-push without MULTI in
1.5.3.9) would be the sane thing we should do in the short term.

Junio C Hamano a écrit > * Do we know that the current code is broken 
for everybody, or just

broken for the majority of people who do nontrivial things?

http-push without USE_CURL_MULTI is broken for everybody who uses it

* Is the code in 1.5.3.8 any better?  IOW, did we make it worse 
during 1.5.4 cycle?

I think it is better, because it hurts less.

after:
- http-push with curl >= 7.16 works
- http-push with curl < 7.16 does not work

before
- http-push with curl >= 7.16 works
- http-push with curl < 7.16 does not work and in addition corrups repos

In addition, the sooner we disable the repo corrupting code, the less we
will have dangerous code in the wide

Junio C Hamano a écrit :

Then I guess Dscho's notice (and the same notice with disabling 
http-push without MULTI in 1.5.3.9) would be the sane thing we should
do in the short term.

This is my opinion.

Junio C Hamano a écrit :
 > The feature was added by one person who needed it, and it was
 > included because the need was satisfid with an implementation,
 > so at some point in the past, it must have worked for _somebody_
 > (I am hoping that this is not a regression during 1.5.4 cycle).
 >
 > Imagine that you are like that somebody who have been happily
 > using http-push.  Or imagine that you are starting to use git
 > and are tempted to use http-push.  With the above wording, I
 > strongly suspect that you would say "Crap --- 1.5.4 does not let
 > me run http-push, so I'll stay at 1.5.3.8 until 1.5.X lets me
 > use it again".

My experience is that 1.5.3.6 is broken too (but I did not ever try 
1.5.3.8). Therefore I don't think it's an 1.5.4 regression.

In fact, a few weeks ago, I was that guy discovering git and trying to 
use http-push, and said "Crap. That thing is broken." And this why I'm 
bothering you all since a while.

-- 
Grégoire Barbier - gb à gbarbier.org - +33 6 21 35 73 49