Re: [PATCH] added #define DEFAULT_MAX_REQUESTS for USE_CURL_MULTI mode

Grégoire Barbier [off-list ref] writes:

Why is this needed?

How does this interact with an existing #define in http.h that
defines it to 5?

Junio C Hamano a écrit :

Grégoire Barbier [off-list ref] writes:
  

quoted

From: Gregoire Barbier <redacted>

I'm not sure of which value is the good one, but 4 seems good since it's
not very high which would lead to resouce consumption problems.
---
 http.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/http.c b/http.c
index 8b04ae9..7b1bcb8 100644
--- a/http.c
+++ b/http.c

@@ -4,6 +4,7 @@ int data_received;
 int active_requests = 0;
 
 #ifdef USE_CURL_MULTI
+#define DEFAULT_MAX_REQUESTS 4
 static int max_requests = -1;
 static CURLM *curlm;
 #endif
    

Why is this needed?

How does this interact with an existing #define in http.h that
defines it to 5?
  

Ok, please forget my patch and forgive my stupidity, I've juste realized 
why I needed to define -DUSE_CURL_MULTI by hand in the Makefile, I'm so 
stupid...

I will answers you other mail and Johannes' later.

-- 
Grégoire Barbier - gb à gbarbier.org - +33 6 21 35 73 49