[PATCH] ls-remote: add -t and -h options.

Subsystems: the rest

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] ls-remote: add -t and -h options.

From: Miklos Vajna <hidden>
Date: 2016-06-15 22:44:05

These options are listed in the manpage (aliases for --tags/--heads) but they
were not handled.

Signed-off-by: Miklos Vajna <redacted>
---

Alternatively, if it's too late to introduce new options, I think we should
remove these options from the manpage, but I prefer the current fix.

 builtin-ls-remote.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin-ls-remote.c b/builtin-ls-remote.c
index c2caeea..6dd31d1 100644
--- a/builtin-ls-remote.c
+++ b/builtin-ls-remote.c
@@ -54,11 +54,11 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)
 				uploadpack = arg + 7;
 				continue;
 			}
-			if (!strcmp("--tags", arg)) {
+			if (!strcmp("--tags", arg) || !strcmp("-t", arg)) {
 				flags |= REF_TAGS;
 				continue;
 			}
-			if (!strcmp("--heads", arg)) {
+			if (!strcmp("--heads", arg) || !strcmp("-h", arg)) {
 				flags |= REF_HEADS;
 				continue;
 			}
-- 
1.5.4.rc3.4.g16335-dirty

Re: [PATCH] ls-remote: add -t and -h options.

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:44:05

Hi,

On Tue, 15 Jan 2008, Miklos Vajna wrote:
These options are listed in the manpage (aliases for --tags/--heads) but 
they were not handled.

Signed-off-by: Miklos Vajna <redacted>
---

Alternatively, if it's too late to introduce new options, I think we 
should remove these options from the manpage, but I prefer the current 
fix.
It's not like you added functionality, but just short option handling.  
IMHO this is perfectly okay, even this late in the 1.5.4 cycle.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help