Re: [PATCH] git stash: one bug and one feature request

Wayne Davison [off-list ref] writes:

On Fri, Jan 04, 2008 at 05:14:42PM +0100, Marco Costalba wrote:

quoted

-		echo >&2 'No local changes to save'
+		echo > 'No local changes to save'

That change and the other two following it each put a newline in a
strangely named file.  You should just drop the >&2 altogether if you
want the output to go to stdout.

Lol...  Good eyes.  I did not even notice it ;-).

Thanks.

On Jan 5, 2008 7:52 AM, Junio C Hamano [off-list ref] wrote:

Wayne Davison [off-list ref] writes:

quoted

On Fri, Jan 04, 2008 at 05:14:42PM +0100, Marco Costalba wrote:

quoted

-            echo >&2 'No local changes to save'
+            echo > 'No local changes to save'

That change and the other two following it each put a newline in a
strangely named file.  You should just drop the >&2 altogether if you
want the output to go to stdout.

Lol...  Good eyes.  I did not even notice it ;-).

Very sorry for this, I should have been more careful. Please let me
know if you want me to resend the patch.

Marco