Re: [PATCH 1/2] Fix config lockfile handling.

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 1/2] Fix config lockfile handling.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:59

Johannes Schindelin [off-list ref] writes:
Hi,

On Fri, 14 Dec 2007, Kristian Høgsberg wrote:
quoted
-	struct lock_file *lock = NULL;
+	struct lock_file lock;
AFAICT this cannot work.  At least not reliably.  An atexit() handler will 
access all (even closed) lockfiles.
Correct.  It cannot be on the stack.

Re: [PATCH 1/2] Fix config lockfile handling.

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:43:59

Hi,

On Fri, 14 Dec 2007, Junio C Hamano wrote:
Johannes Schindelin [off-list ref] writes:
quoted
On Fri, 14 Dec 2007, Kristian Høgsberg wrote:
quoted
-	struct lock_file *lock = NULL;
+	struct lock_file lock;
AFAICT this cannot work.  At least not reliably.  An atexit() handler 
will access all (even closed) lockfiles.
Correct.  It cannot be on the stack.
Note that this behaviour will be another obstacle to libification.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help