StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:43:59

The command I used quite often in my StGIT workflow, namely 
"stg refresh -e", which used to refresh patch and launch editor to edit 
commit (patch) description no longer works in Stacked GIT 0.14.1.

I used it when new (refreshed) changes needed also changes in commit 
description (commit message). Now I have to run two commands: 
"stg refresh" and "stg edit".

-- 
Jakub Narebski
Poland

Re: StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works

From: Catalin Marinas <hidden>
Date: 2016-06-15 22:43:59

On 14/12/2007, Jakub Narebski [off-list ref] wrote:
The command I used quite often in my StGIT workflow, namely
"stg refresh -e", which used to refresh patch and launch editor to edit
commit (patch) description no longer works in Stacked GIT 0.14.1.

I used it when new (refreshed) changes needed also changes in commit
description (commit message). Now I have to run two commands:
"stg refresh" and "stg edit".
Well, people complained that 'refresh -e' is misleading and a separate
command is needed. It's not difficult to move the editing
functionality out of stgit.commands.edit and re-add the --edit option
to refresh (while also keeping the separate edit command).

I'm a bit busy with home/family commitments until the new year.

-- 
Catalin

Re: StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:43:59

On Fri, 14 Dec 2007, Catalin Marinas wrote:
On 14/12/2007, Jakub Narebski [off-list ref] wrote:
quoted
The command I used quite often in my StGIT workflow, namely
"stg refresh -e", which used to refresh patch and launch editor to edit
commit (patch) description no longer works in Stacked GIT 0.14.1.

I used it when new (refreshed) changes needed also changes in commit
description (commit message). Now I have to run two commands:
"stg refresh" and "stg edit".
Well, people complained that 'refresh -e' is misleading and a separate
command is needed. It's not difficult to move the editing
functionality out of stgit.commands.edit and re-add the --edit option
to refresh (while also keeping the separate edit command).
First, the "misleading" part could be corrected by renaming long option
to --edit-description or --edit-message. Second "stg refresh -e" matches
non-StGIT usage of "git commit --amend"; and it is damn useful to have
it as one command, not two. 
I'm a bit busy with home/family commitments until the new year.
I'll wait. As I am not running StGIT master, but released version,
I would have to waith nevertheless on next release.

TIA
-- 
Jakub Narebski
Poland
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help