[PATCH] Fix clone not to ignore depth when performing a local clone

Subsystems: the rest

DORMANTno replies

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] Fix clone not to ignore depth when performing a local clone

From: Charles Bailey <hidden>
Date: 2016-06-15 22:43:58

When git-clone detects that it can perform a local clone it
follows a path that silently ignores the depth parameter.

Presumably if the user explicitly requests a shallow clone they
have a reason to prefer a space efficient clone of just the recent
history so bypass the local magic if the user specifies the depth
parameter.

Signed-off-by: Charles Bailey <redacted>
---
 git-clone.sh |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/git-clone.sh b/git-clone.sh
index ecf9d89..fb124d8 100755
--- a/git-clone.sh
+++ b/git-clone.sh
@@ -205,7 +205,10 @@ fi
 # it is local
 if base=$(get_repo_base "$repo"); then
 	repo="$base"
-	local=yes
+	if test -z "$depth"
+	then
+		local=yes
+	fi
 fi
 
 dir="$2"
-- 
1.5.3.7.2242.gcc945-dirty

Re: [PATCH] Fix clone not to ignore depth when performing a local clone

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:43:58

Hi,

On Tue, 11 Dec 2007, Charles Bailey wrote:
quoted hunk
@@ -205,7 +205,10 @@ fi
 # it is local
 if base=$(get_repo_base "$repo"); then
 	repo="$base"
-	local=yes
+	if test -z "$depth"
+	then
+		local=yes
+	fi
 fi
Or shorter:

-	local=yes
+	test -z "$depth" && local=yes

Ciao,
Dscho

Re: [PATCH] Fix clone not to ignore depth when performing a local clone

From: Charles Bailey <hidden>
Date: 2016-06-15 22:43:58

On Tue, Dec 11, 2007 at 11:54:54AM +0000, Johannes Schindelin wrote:
Hi,

On Tue, 11 Dec 2007, Charles Bailey wrote:
quoted
@@ -205,7 +205,10 @@ fi
 # it is local
 if base=$(get_repo_base "$repo"); then
 	repo="$base"
-	local=yes
+	if test -z "$depth"
+	then
+		local=yes
+	fi
 fi
Or shorter:

-	local=yes
+	test -z "$depth" && local=yes

Ciao,
Dscho
Yes, I have no particular preference. I was just following the
'convention' of the -z "$origin" test a few lines above although
I could see uses of both alternatives as well as instances of [...]
instead of test ... .

Charles.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help