Re: [PATCH] t9600: require cvsps 2.1 to perform tests

Jeff King [off-list ref] writes:

On Mon, Dec 03, 2007 at 09:37:54PM -0800, Junio C Hamano wrote:

quoted

I wonder if it is better to grep for ' [-A] ' instead, like:

cvsps_supports_A=$(cvsps -h 2>&1 | sed -ne '/\[-A\]/p')
case "$cvsps_supports_A" in
'')
	say 'skipping cvsimport tests, lacking cvsps that supports -A option'
	test_done
        exit
esac

I am not too opposed to that, but I felt that checking the version was a
little bit more future proof. I.e., I have no idea if it is only -A that
we need, but I know that 2.1 works and prior to 2.1 doesn't.

You are right about "we may be depending on what 2.1 has other than
-A".  Will apply as-is.

Thanks, both.

The primary reason I asked about '\[-A\]' was what will happen if
somebody uses 2.2.

On Tue, Dec 04, 2007 at 09:39:59AM -0800, Junio C Hamano wrote:

You are right about "we may be depending on what 2.1 has other than
-A".  Will apply as-is.

Thanks, both.

The primary reason I asked about '\[-A\]' was what will happen if
somebody uses 2.2.

Yes, it would be nice to be able to easily check >2.1. GNU expr seems to
handle this ok:

  $ expr 2.2 '>' 2.1
  1
  $ expr 2.0 '>' 2.1
  0

but POSIX seems to mention only integers and string comparison (though
if all are of the form "x.y", string comparison works). I have no idea
how portable this is.

-Peff