Re: git-add--interactive works only in top level

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: git-add--interactive works only in top level

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:56

Reid Barton [off-list ref] writes:
When the working directory is not the top of the working tree, git-
add--interactive fails silently and confusingly.
Sheesh, you got me worried.

This is a non issue; git-add--interactive is not for direct end user
consumption.  It relies on being run from git-add wrapper, which does
cdup to the top of the work tree before launching add--interactive
helper.

Re: git-add--interactive works only in top level

From: Reid Barton <hidden>
Date: 2016-06-15 22:43:56

On Dec 4, 2007, at 12:44 AM, Junio C Hamano wrote:
Sheesh, you got me worried.

This is a non issue; git-add--interactive is not for direct end user
consumption.  It relies on being run from git-add wrapper, which does
cdup to the top of the work tree before launching add--interactive
helper.
Ah, OK.  Would it not be easy then to add a check to the beginning of  
git-add--interactive to verify that it is indeed being run from the  
top of the work tree?  A user may well discover git-add--interactive  
before git-add --interactive (e.g. by shell completion) and if git- 
add--interactive is going to fail, it should do so right away so as  
to not confuse the user.

I understand that programs such as git-add--interactive will be moved  
out of the executable path not too long from now, which will also  
ameliorate the situation.

Regards,
Reid Barton
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help