[PATCH] Set OLD_ICONV on Cygwin.

Subsystems: kernel build + files below scripts/ (unless maintained elsewhere), the rest

STALE3714d

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

[PATCH] Set OLD_ICONV on Cygwin.

From: Pascal Obry <hidden>
Date: 2016-06-15 22:43:55

Cygwin still has old definition for the iconv() second
parameter. This patch fixes the last warning on Cygwin.
This has been tested with Cygwin 1.5.24.

Signed-off-by: Pascal Obry <redacted>
---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index e869b85..fa3398c 100644
--- a/Makefile
+++ b/Makefile
@@ -446,6 +446,7 @@ ifeq ($(uname_O),Cygwin)
 	NEEDS_LIBICONV = YesPlease
 	NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
 	NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
+	OLD_ICONV = UnfortunatelyYes
 	# There are conflicting reports about this.
 	# On some boxes NO_MMAP is needed, and not so elsewhere.
 	# Try commenting this out if you suspect MMAP is more efficient
-- 
1.5.3.6.985.g65c6a4

Re: [PATCH] Set OLD_ICONV on Cygwin.

From: Pascal Obry <hidden>
Date: 2016-06-15 22:43:55

I pretty well understand that this patch is not very important but since
I got no reply I'm wondering if there is something wrong with it ?

Pascal.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595

Re: [PATCH] Set OLD_ICONV on Cygwin.

From: Andreas Ericsson <hidden>
Date: 2016-06-15 22:43:56

Pascal Obry wrote:
I pretty well understand that this patch is not very important but since
I got no reply I'm wondering if there is something wrong with it ?
Only one, insofar as I can see; You didn't CC Junio. He probably missed it.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help