Re: [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR

From: David Kastrup <hidden>
Date: 2016-06-15 22:43:54

"Nguyen Thai Ngoc Duy" [off-list ref] writes:
On Nov 28, 2007 8:57 PM, Johannes Schindelin [off-list ref] wrote:
quoted
It might be POSIX, but there are shells that do not like the
expression 'export VAR=VAL'.  To be on the safe side, rewrite them
into 'VAR=VAL' and 'export VAR'.
Why leave test scripts behind?
Good keyword: how about starting the basic tests by testing for shell
features that are known and accepted to be used in git?

That way, we get direct feedback when feature assumptions are
problematic with some shells.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

Re: [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR

From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:43:54

On Nov 28, 2007 9:24 PM, David Kastrup [off-list ref] wrote:
"Nguyen Thai Ngoc Duy" [off-list ref] writes:
quoted
On Nov 28, 2007 8:57 PM, Johannes Schindelin [off-list ref] wrote:
quoted
It might be POSIX, but there are shells that do not like the
expression 'export VAR=VAL'.  To be on the safe side, rewrite them
into 'VAR=VAL' and 'export VAR'.
Why leave test scripts behind?
Good keyword: how about starting the basic tests by testing for shell
features that are known and accepted to be used in git?

That way, we get direct feedback when feature assumptions are
problematic with some shells.
Uh.. I meant there are "export VAL=VAL" usage in test scripts and they
should be fixed as well. Anyway your idea is nice.
-- 
Duy

Re: [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:43:54


On Wed, 28 Nov 2007, Nguyen Thai Ngoc Duy wrote:
quoted
how about starting the basic tests by testing for shell features that 
are known and accepted to be used in git?

That way, we get direct feedback when feature assumptions are 
problematic with some shells.
Uh.. I meant there are "export VAL=VAL" usage in test scripts and they 
should be fixed as well. Anyway your idea is nice.
I have an even better idea: how about getting rid of all shell scripts, 
making them builtins? ;-)

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help