Wincent Colaiuta [off-list ref] writes:
El 25/11/2007, a las 19:07, Junio C Hamano escribi> The earlier 7c0ab4458994aa895855abc4a504cf693ecc0cf1 (Teach builtin-
quoted
add
to pass multiple paths to git-add--interactive) did not allocate
enough,
Yes, it was off by one; sorry about that. You may have noticed that I
fixed that up in the patches I sent out yesterday and today. May need
to redo them now to apply on top of this.
I'd suggest you to slow down, apply the two patches on top of 'next' and
take a look at the result.
I _think_ the only remaining thing is --patch, and none of the pathspec
thing is needed.
El 25/11/2007, a las 19:36, Junio C Hamano escribió:
I _think_ the only remaining thing is --patch, and none of the
pathspec
thing is needed.
You're probably right; the pathspec validation is probably not
necessary (and you may recall that my original patch didn't include
it; I only tried adding after you said it might be appropriate to have
the "--error-unmatch" behaviour). This is probably more convenient for
the user, as it allows them to pass "sloppy" parameters like the
following:
git-add -i *.h
(Note that's "*.h" and not "\*.h"). In the Git repository, without
validation, this just works. With strict validation, it would complain:
error: pathspec 'common-cmds.h' did not match any file(s) known to git.
So just forgetting about the validation is probably the right thing to
do.
As for adding the --patch option, I'll stand back and see if someone
more skilled than I wants to do it; should only be a few lines and
will save traffic to the list because they'll probably get it right
first time.
Cheers,
Wincent