2 messages, 2 authors, 2016-06-15 · open the first message on its own page
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:53
Dan Zwell [off-list ref] writes:
diff --git a/perl/Git.pm b/perl/Git.pm index dca92c8..6603762 100644 --- a/perl/Git.pm +++ b/perl/Git.pm@@ -508,7 +508,7 @@ sub config { my $E = shift; if ($E->value() == 1) { # Key not found. - return undef; + return; } else { throw $E; }
Shouldn't the same fix made to config_bool as well?
From: Dan Zwell <hidden>
Date: 2016-06-15 22:43:53
Junio C Hamano wrote:
Dan Zwell [off-list ref] writes:quoted
diff --git a/perl/Git.pm b/perl/Git.pm index dca92c8..6603762 100644 --- a/perl/Git.pm +++ b/perl/Git.pm@@ -508,7 +508,7 @@ sub config { my $E = shift; if ($E->value() == 1) { # Key not found. - return undef; + return; } else { throw $E; }Shouldn't the same fix made to config_bool as well?
I didn't realize it at the time, but yes, config_bool needs this (though the only time config_bool is evaluated in a list context should be when it is evaluated as an argument to another function). I'll make the change. Dan