Re: [StGit PATCH] Added test case for stg refresh

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [StGit PATCH] Added test case for stg refresh

From: David Kågedal <hidden>
Date: 2016-06-15 22:43:53

"Catalin Marinas" [off-list ref] writes:
On 21/11/2007, Karl Hasselström [off-list ref] wrote:
quoted
On 2007-11-21 11:43:00 +0100, David Kågedal wrote:
quoted
David Kågedal [off-list ref] writes:
quoted
This test case fails on the kha/experimental branch. Using "stg
refresh -p <patch>" can cause all sorts of wieirdness, and there
is no test case for it.
I noticed the weirdness few days ago and fixed it in
e8813959aa3a7c41ffef61d06068b10519bd4830 (though no test caught it).
Do you still see problems after this commit?
The problem I see is that there still is no test case. That is bad and
means that it could break again tomorrow without anyone noticing.

Luckily, I just wrote one for you :-)

-- 
David Kågedal

Re: [StGit PATCH] Added test case for stg refresh

From: Catalin Marinas <hidden>
Date: 2016-06-15 22:43:53

On 22/11/2007, David Kågedal [off-list ref] wrote:
"Catalin Marinas" [off-list ref] writes:
quoted
I noticed the weirdness few days ago and fixed it in
e8813959aa3a7c41ffef61d06068b10519bd4830 (though no test caught it).
Do you still see problems after this commit?
The problem I see is that there still is no test case. That is bad and
means that it could break again tomorrow without anyone noticing.

Luckily, I just wrote one for you :-)
Thanks :-). We are still far from testing all the possible
combinations. Is there a way to do code coverage in Python?

-- 
Catalin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help