Gerrit Pape [off-list ref] writes:
$committer is already extracted from the latest existing rev, so add the
corresponding From: line to the email header.
You may fight this out with Andy if you want to, but I think I'd
side with the existing behaviour.
commit e6dc8d60fbd2c84900a26545c5d360b0e202d95b
Author: Andy Parkins [off-list ref]
Date: Fri Sep 28 15:24:26 2007 +0100
post-receive-hook: Remove the From field from the generated email header so that the pusher's name is used
Using the name of the committer of the revision at the tip of the
updated ref is not sensible. That information is available in the email
itself should it be wanted, and by supplying a "From", we were
effectively hiding the person who performed the push - which is useful
information in itself.
Signed-off-by: Andy Parkins [off-list ref]
Signed-off-by: Junio C Hamano [off-list ref]
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index 1f88099..cbbd02f 100644
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -177,7 +177,6 @@ generate_email_header()
# --- Email (all stdout will be the email)
# Generate header
cat <<-EOF
- From: $committer
To: $recipients
Subject: ${EMAILPREFIX}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe
X-Git-Refname: $refnameJunio C Hamano wrote:
Gerrit Pape [off-list ref] writes:
quoted
$committer is already extracted from the latest existing rev, so add the
corresponding From: line to the email header.
You may fight this out with Andy if you want to, but I think I'd
side with the existing behaviour.
I'm with Andy here, for the reasons stated below.
commit e6dc8d60fbd2c84900a26545c5d360b0e202d95b
Author: Andy Parkins [off-list ref]
Date: Fri Sep 28 15:24:26 2007 +0100
post-receive-hook: Remove the From field from the generated email header so that the pusher's name is used
Using the name of the committer of the revision at the tip of the
updated ref is not sensible. That information is available in the email
itself should it be wanted, and by supplying a "From", we were
effectively hiding the person who performed the push - which is useful
information in itself.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Signed-off-by: Gerrit Pape <redacted>
---
contrib/hooks/post-receive-email | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index 3904c18..7511ea0 100644
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -156,10 +156,6 @@ generate_email()
fi
# Email parameters
- # The committer will be obtained from the latest existing rev; so
- # for a deletion it will be the oldrev, for the others, then newrev
- committer=$(git show --pretty=full -s $rev | sed -ne "s/^Commit: //p" |
- sed -ne 's/\(.*\) </"\1" </p')
# The email subject will contain the best description of the ref
# that we can build from the parameters
describe=$(git describe $rev 2>/dev/null)
--
1.5.3.5
On Nov 8, 2007, at 10:55 AM, Junio C Hamano wrote:
Gerrit Pape [off-list ref] writes:
quoted
$committer is already extracted from the latest existing rev, so
add the
corresponding From: line to the email header.
You may fight this out with Andy if you want to, but I think I'd
side with the existing behaviour.
commit e6dc8d60fbd2c84900a26545c5d360b0e202d95b
Author: Andy Parkins [off-list ref]
Date: Fri Sep 28 15:24:26 2007 +0100
post-receive-hook: Remove the From field from the generated
email header so that the pusher's name is used
Using the name of the committer of the revision at the tip of the
updated ref is not sensible. That information is available in
the email
itself should it be wanted, and by supplying a "From", we were
effectively hiding the person who performed the push - which is
useful
information in itself.
Signed-off-by: Andy Parkins [off-list ref]
Signed-off-by: Junio C Hamano [off-list ref]
Hi guys,
the problem with this change is that when one uses Gitosis all the
commits are pushed with the `git' user so emails always appear to
come from git@fqdn. I guess it would be worth to add an option to
retain the old behavior (where $committer was extracted from the last
commit pushed and used in the `From' field), don't you think?
--
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory