Re: [PATCH amend] git-mailsplit: with maildirs not only process cur/, but also new/

Gerrit Pape [off-list ref] writes:

When saving patches to a maildir with e.g. mutt, the files are put into
the new/ subdirectory of the maildir, not cur/.  This makes git-am state
"Nothing to do.".  This patch lets git-mailsplit additional check new/
after reading cur/.

This was reported by Joey Hess through
 http://bugs.debian.org/447396

Signed-off-by: Gerrit Pape <redacted>
---

On Mon, Nov 05, 2007 at 01:58:50PM +0100, Jakub Narebski wrote:

quoted

quoted

+        for (i = 0; i < 2; ++i) {

Wouldn't it be better to use sizeof(sub)/sizeof(sub[0]) or it's macro
equivalent ARRAY_SIZE(sub) instead of hardcoding 2 to avoid errors?

I made the array NULL-terminated.

On Mon, Nov 05, 2007 at 04:26:24PM -0500, Jeff King wrote:

quoted

Isn't the subject line now wrong?

Yes, thanks.

On Mon, Nov 05, 2007 at 11:52:58PM +0100, Alex Riesen wrote:

quoted

Why is missing "cur" (or "new", for that matter) a fatal error?
Why is it error at all? How about just ignoring the fact?

As suggested by Jeff, I made it ignore the error on ENOENT.

Looks good to me.  Final acks please?

On Wed, Nov 07, 2007 at 06:09:26PM -0800, Junio C Hamano wrote:

quoted

When saving patches to a maildir with e.g. mutt, the files are put into
the new/ subdirectory of the maildir, not cur/.  This makes git-am state
"Nothing to do.".  This patch lets git-mailsplit additional check new/
after reading cur/.

Looks good to me.  Final acks please?

Fixed my concerns.

Acked-by: Jeff King <redacted>

-Peff

Junio C Hamano, Thu, Nov 08, 2007 03:09:26 +0100:

Gerrit Pape [off-list ref] writes:

quoted

When saving patches to a maildir with e.g. mutt, the files are put into
the new/ subdirectory of the maildir, not cur/.  This makes git-am state
"Nothing to do.".  This patch lets git-mailsplit additional check new/
after reading cur/.

This was reported by Joey Hess through
 http://bugs.debian.org/447396

Signed-off-by: Gerrit Pape <redacted>
---

On Mon, Nov 05, 2007 at 01:58:50PM +0100, Jakub Narebski wrote:

quoted

quoted

+        for (i = 0; i < 2; ++i) {

Wouldn't it be better to use sizeof(sub)/sizeof(sub[0]) or it's macro
equivalent ARRAY_SIZE(sub) instead of hardcoding 2 to avoid errors?

I made the array NULL-terminated.

On Mon, Nov 05, 2007 at 04:26:24PM -0500, Jeff King wrote:

quoted

Isn't the subject line now wrong?

Yes, thanks.

On Mon, Nov 05, 2007 at 11:52:58PM +0100, Alex Riesen wrote:

quoted

Why is missing "cur" (or "new", for that matter) a fatal error?
Why is it error at all? How about just ignoring the fact?

As suggested by Jeff, I made it ignore the error on ENOENT.

Better.

Looks good to me.  Final acks please?

Acked-by: Alex Riesen <redacted>

On Wed, Nov 07, 2007 at 06:09:26PM -0800, Junio C Hamano wrote:

Gerrit Pape [off-list ref] writes:

quoted

When saving patches to a maildir with e.g. mutt, the files are put into
the new/ subdirectory of the maildir, not cur/.  This makes git-am state
"Nothing to do.".  This patch lets git-mailsplit additional check new/
after reading cur/.

This was reported by Joey Hess through
 http://bugs.debian.org/447396

Signed-off-by: Gerrit Pape <redacted>
---

On Mon, Nov 05, 2007 at 01:58:50PM +0100, Jakub Narebski wrote:

quoted

quoted

+        for (i = 0; i < 2; ++i) {

Wouldn't it be better to use sizeof(sub)/sizeof(sub[0]) or it's macro
equivalent ARRAY_SIZE(sub) instead of hardcoding 2 to avoid errors?

I made the array NULL-terminated.

On Mon, Nov 05, 2007 at 04:26:24PM -0500, Jeff King wrote:

quoted

Isn't the subject line now wrong?

Yes, thanks.

On Mon, Nov 05, 2007 at 11:52:58PM +0100, Alex Riesen wrote:

quoted

Why is missing "cur" (or "new", for that matter) a fatal error?
Why is it error at all? How about just ignoring the fact?

As suggested by Jeff, I made it ignore the error on ENOENT.

Looks good to me.  Final acks please?

Fixed my concern too.

Acked-by: Fernando J. Pereda <redacted>

-- 
Fernando J. Pereda Garcimartín
20BB BDC3 761A 4781 E6ED  ED0B 0A48 5B0C 60BD 28D4