Re: [PATCH] fix display overlap between remote and local progress

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] fix display overlap between remote and local progress

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:47

Nicolas Pitre [off-list ref] writes:
On Sun, 4 Nov 2007, Johannes Schindelin wrote:
quoted
On Sun, 4 Nov 2007, Nicolas Pitre wrote:
quoted
+#define SUFFIX "\e[K"  /* change to "        " if ANSI sequences don't work */ 
I am almost certain (without even testing) that cmd.exe has problems with 
that.  It does not even understand colorisation.
That's what I was expecting.  This is why I suggested an alternative in 
the comment.
That's fine --- cmd.exe weenies can patch it away ;-).

The compiler at k.org complains of "\e" being non ISO-C, though.

Re: [PATCH] fix display overlap between remote and local progress

From: Nicolas Pitre <hidden>
Date: 2016-06-15 22:43:47

On Sun, 4 Nov 2007, Junio C Hamano wrote:
The compiler at k.org complains of "\e" being non ISO-C, though.
Bummer.

...

Signed-off-by: Nicolas Pitre <redacted>
---
diff --git a/sideband.c b/sideband.c
index 58edea6..756bbc2 100644
--- a/sideband.c
+++ b/sideband.c
@@ -13,7 +13,7 @@
  */
 
 #define PREFIX "remote:"
-#define SUFFIX "\e[K"  /* change to "        " if ANSI sequences don't work */
+#define SUFFIX "\033[K"  /* change to "        " if ANSI sequences don't work */
 
 int recv_sideband(const char *me, int in_stream, int out, int err)
 {
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help