Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:46

Jakub Narebski [off-list ref] writes:

It does appear to do nothing; gitweb is run as standalone program
and not as CGI script in this test.  This call caused problems later.

Care to describe "later problems" a bit more?

quoted hunk

Signed-off-by: Jakub Narebski <redacted>
---
 t/t9500-gitweb-standalone-no-errors.sh |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
index f7bad5b..1bf0988 100755
--- a/t/t9500-gitweb-standalone-no-errors.sh
+++ b/t/t9500-gitweb-standalone-no-errors.sh

@@ -31,7 +31,6 @@ our \$projects_list = "";
 our \$export_ok = "";
 our \$strict_export = "";
 
-CGI::Carp::set_programname("gitweb/gitweb.cgi");
 EOF
 
 	cat >.git/description <<EOF

-- 
1.5.3.5

Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:43:46

Junio C Hamano wrote:

Jakub Narebski [off-list ref] writes:

quoted

It does appear to do nothing; gitweb is run as standalone program
and not as CGI script in this test.  This call caused problems later.

Care to describe "later problems" a bit more?

Sorry about that. The problems were while creating yet-to-be send
patch
  "gitweb: Add tests for overriding gitweb config with repo config"
Perhaps not in the current version. I forgot details.

Perhaps last sentence "This call caused problems later." should be
simply removed from commit message.

-- 
Jakub Narebski
Poland

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help