Re: [PATCH 1/1] Add --first-parent support to interactive rebase.

Jeff King [off-list ref] writes:

On Wed, Oct 31, 2007 at 03:31:20PM -0700, Junio C Hamano wrote:

quoted

quoted

... I had one concern that
I was tracking down: is the author name encoding necessarily the same as
the commit text encoding?

The user is screwing himself already if that is the case and
uses -s to format-patch, isn't he?

Hrm, they probably _should_ be the same in the output. It's not clear to
me what encoding we assume the name comes in (utf-8, I guess). Looks
like we don't touch it at all when putting it in the signoff. I think we
should just be able to reencode when appending the signoff; patch is
below.

I think assuming utf-8 and reencoding is actively wrong.
Existing setups of people with names that cannot be expressed in
ASCII would already have the commit encoding specified in the
configuration and user.name stored in that encoding, so passing
things through as we have always done is the right thing to do.

On Wed, Oct 31, 2007 at 09:10:30PM -0700, Junio C Hamano wrote:

I think assuming utf-8 and reencoding is actively wrong.
Existing setups of people with names that cannot be expressed in
ASCII would already have the commit encoding specified in the
configuration and user.name stored in that encoding, so passing
things through as we have always done is the right thing to do.

That will break any time somebody uses -s with a --encoding= that is
different from their usual encoding. My patch assumes the source is
utf-8, but should perhaps assume some other default encoding from the
config.

But if this is not a problem for people, I'm not going to push it. I
don't actually use any of these features; it was just something I
noticed while looking at the actual bug.

-Peff