Re: git-merge: inconsistent manual page.

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: git-merge: inconsistent manual page.

From: Sergei Organov <hidden>
Date: 2016-06-15 22:43:45

Junio C Hamano [off-list ref] writes:
Subject: git-merge: document but discourage the historical syntax

Historically "git merge" took its command line arguments in a
rather strange order.  Document the historical syntax, and also
document clearly that it is not encouraged in new scripts.

There is no reason to deprecate the historical syntax, as the
current code can sanely tell which syntax the caller is using,
and existing scripts by people do use the historical syntax.
OK, your patch is better than what I've suggested. The only thing that
your patch seems to be missing is prepending -m to <msg>:: in the
OPTIONS section. Yeah, it could be more strict to just describe <msg>,
but if there were no historical syntax, then you'd put '-m <msg>'
description in, right? So the latter might be better anyway.

-- 
Sergei.

Re: git-merge: inconsistent manual page.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:45

Sergei Organov [off-list ref] writes:
Junio C Hamano [off-list ref] writes:
quoted
Subject: git-merge: document but discourage the historical syntax

Historically "git merge" took its command line arguments in a
rather strange order.  Document the historical syntax, and also
document clearly that it is not encouraged in new scripts.

There is no reason to deprecate the historical syntax, as the
current code can sanely tell which syntax the caller is using,
and existing scripts by people do use the historical syntax.
OK, your patch is better than what I've suggested. The only thing that
your patch seems to be missing is prepending -m to <msg>:: in the
OPTIONS section. Yeah, it could be more strict to just describe <msg>,
...
Nah, you are absolutely right.  We describe "-s <strategy>"
under the headline with the leading "-s".

Will fix.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help