[PATCH] git-config: don't silently ignore options after --list
From: Frank Lichtenheld <hidden>
Date: 2016-06-15 22:43:39
Subsystem:
the rest · Maintainer:
Linus Torvalds
Error out if someone gives options after --list since that is not a valid syntax. Signed-off-by: Frank Lichtenheld <redacted> --- builtin-config.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) Two minutes of my life I don't get back ;)
diff --git a/builtin-config.c b/builtin-config.c
index 0a605e0..cb7e9e9 100644
--- a/builtin-config.c
+++ b/builtin-config.c@@ -172,8 +172,11 @@ int cmd_config(int argc, const char **argv, const char *prefix) type = T_INT; else if (!strcmp(argv[1], "--bool")) type = T_BOOL; - else if (!strcmp(argv[1], "--list") || !strcmp(argv[1], "-l")) + else if (!strcmp(argv[1], "--list") || !strcmp(argv[1], "-l")) { + if (argc != 2) + usage(git_config_set_usage); return git_config(show_all_config); + } else if (!strcmp(argv[1], "--global")) { char *home = getenv("HOME"); if (home) {
--
1.5.3.4