Re: [PATCH] Move option parsing code to parse-options.[ch].

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] Move option parsing code to parse-options.[ch].

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:36

Kristian Høgsberg [off-list ref] writes:
Signed-off-by: Kristian Høgsberg <redacted>
---
 Makefile         |    2 +-
 builtin-commit.c |  117 ++++++++----------------------------------------------
 parse-options.c  |   74 ++++++++++++++++++++++++++++++++++
 parse-options.h  |   29 +++++++++++++
 4 files changed, 121 insertions(+), 101 deletions(-)
 create mode 100644 parse-options.c
 create mode 100644 parse-options.h
Hmmmmmmm. Is it too much to ask to pretend as if the previous
"builtin-commit.c" that had these parts that did not belong to
it in the first place never happened?

Re: [PATCH] Move option parsing code to parse-options.[ch].

From: Kristian Høgsberg <hidden>
Date: 2016-06-15 22:43:36

On Fri, 2007-09-21 at 12:44 -0700, Junio C Hamano wrote:
Kristian Høgsberg [off-list ref] writes:
quoted
Signed-off-by: Kristian Høgsberg <redacted>
---
 Makefile         |    2 +-
 builtin-commit.c |  117 ++++++++----------------------------------------------
 parse-options.c  |   74 ++++++++++++++++++++++++++++++++++
 parse-options.h  |   29 +++++++++++++
 4 files changed, 121 insertions(+), 101 deletions(-)
 create mode 100644 parse-options.c
 create mode 100644 parse-options.h
Hmmmmmmm. Is it too much to ask to pretend as if the previous
"builtin-commit.c" that had these parts that did not belong to
it in the first place never happened?
No problem, I wasn't sure whether to update the patches or to just send
follow-up patches now that it was in pu.  I'll resend 7/7 as 3 new
patches that exports add_files_to_cache(), adds option parsing, and
finally builtin-commit.

Kristian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help