Re: [PATCH 3/3] git-apply: add tests for stripping of leading and trailing whitespace

"J. Bruce Fields" [off-list ref] writes:

+test_expect_success \
+	'8 or more consecutive initial spaces' \
+	'checkstrip 4'

It may be valid, some projects use tabs for indentation and spaces
for alignment, e.g.:

	if (cond && (cond1 ||
	             cond2))
		...

The second line is actually:
	             cond2))
<TAB--->SSSSSSSSSSSSScond2))
where 'S' means space.

This is the only way to write code which display correctly with
different tab sizes.

With tab = 4 spaces it would be expanded to:
    if (cond && (cond1 ||
                 cond2))
        ...
I.e., it would be still fine.


Most of the formating tools probably can't do it automatically.
-- 
Krzysztof Halasa

On Mon, Sep 17, 2007 at 04:16:07PM +0200, Krzysztof Halasa wrote:

"J. Bruce Fields" [off-list ref] writes:

quoted

+test_expect_success \
+	'8 or more consecutive initial spaces' \
+	'checkstrip 4'

It may be valid, some projects use tabs for indentation and spaces
for alignment, e.g.:

Yeah, I know.  I was hoping that the stripspace behavior was already
specific enough to the linux-kernel style that we could just assume that 
it was only used by developers on projects with the same style.  I agree
that I was wrong--apologies.

--b.