Re: [PATCH] New strbuf APIs: splice and attach.

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] New strbuf APIs: splice and attach.

From: Florian Weimer <hidden>
Date: 2016-06-15 22:43:34

* Pierre Habouzit:
+void strbuf_grow(struct strbuf *sb, size_t extra)
+{
 	if (sb->len + extra + 1 <= sb->len)
 		die("you want to use way too much memory");
By the way, this comparison is always false because sb->len is signed.

Re: [PATCH] New strbuf APIs: splice and attach.

From: Pierre Habouzit <hidden>
Date: 2016-06-15 22:43:35

On Sun, Sep 16, 2007 at 08:20:06PM +0000, Florian Weimer wrote:
* Pierre Habouzit:
quoted
+void strbuf_grow(struct strbuf *sb, size_t extra)
+{
 	if (sb->len + extra + 1 <= sb->len)
 		die("you want to use way too much memory");
By the way, this comparison is always false because sb->len is signed.
  News to me. Actually it's not, it's a size_t :)

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help