[PATCH] fix memleak from tree pathspec in git-blame
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:33
Subsystem:
the rest · Maintainer:
Linus Torvalds
We repeatedly run diff-tree while finding code movements. The pathspec data is changed into a list of paths and their lengths for quicker access by diff_tree_setup_paths(), and you need to release the extra memory when you are done using that pathspec data. Not releasing it is not a problem for "git log -- path" (or its plumbing equivalent "git rev-list -- paths"), because the pathspec never changes during the traversal, but it was noticeable for blame especially with -C -C. Signed-off-by: Junio C Hamano <redacted> --- builtin-blame.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/builtin-blame.c b/builtin-blame.c
index dc88a95..aace08c 100644
--- a/builtin-blame.c
+++ b/builtin-blame.c@@ -380,6 +380,7 @@ static struct origin *find_origin(struct scoreboard *sb, } } diff_flush(&diff_opts); + diff_tree_release_paths(&diff_opts); if (porigin) { /* * Create a freestanding copy that is not part of
@@ -436,6 +437,7 @@ static struct origin *find_rename(struct scoreboard *sb, } } diff_flush(&diff_opts); + diff_tree_release_paths(&diff_opts); return porigin; }
@@ -1157,6 +1159,7 @@ static int find_copy_in_parent(struct scoreboard *sb, } } diff_flush(&diff_opts); + diff_tree_release_paths(&diff_opts); return retval; }