Re: git-svn: Protect against "diff.color = true".

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: git-svn: Protect against "diff.color = true".

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:32

Johannes Schindelin [off-list ref] writes:
On Fri, 31 Aug 2007, Junio C Hamano wrote:
quoted
  I do not have an easy access to SVN repo
  to interoperate with, so a testing by real-world users and an
  Ack is appreciated.
I just tested on a busybox clone: Works as expected.  Without your patch, 
I get the uninitialised values, with your patch it is fine.

ACK.
Thanks.

It's customary that the privilege to issue Ack is reserved to
the primary owner of the code.  We are a relatively small
friendly community and it is not a big deal, but if you ever
work on the kernel, be somewhat more careful.  People are picky
over there on such details.

Re: git-svn: Protect against "diff.color = true".

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:43:32

Hi,

On Fri, 31 Aug 2007, Junio C Hamano wrote:
Johannes Schindelin [off-list ref] writes:
quoted
On Fri, 31 Aug 2007, Junio C Hamano wrote:
quoted
  I do not have an easy access to SVN repo
  to interoperate with, so a testing by real-world users and an
  Ack is appreciated.
I just tested on a busybox clone: Works as expected.  Without your patch, 
I get the uninitialised values, with your patch it is fine.

ACK.
Thanks.

It's customary that the privilege to issue Ack is reserved to
the primary owner of the code.  We are a relatively small
friendly community and it is not a big deal, but if you ever
work on the kernel, be somewhat more careful.  People are picky
over there on such details.
Happily, we are a much friendlier bunch here ;-)

Besides, since I feel we're really close to 1.5.3 now, I thought that you 
might want to here as many positive votes as you can get.

But yes, I'll keep that in mind ;-)

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help