Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d)

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d)

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:32

Junio C Hamano [off-list ref] writes:
I was almost going to suggest us to change "*.color = true" to
mean 'auto'.  Because git can internally use pager and has a way
for the user to control enabling/disabling colors when the pager
is used, there is no _logical_ reason to enable pager when the
output is not going to a tty.
Gaah, sorry; I meant "no logical reason to enable _color_ when
the output is not going to a tty".

Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d)

From: Sam Vilain <hidden>
Date: 2016-06-15 22:43:32

Junio C Hamano wrote:
quoted
I was almost going to suggest us to change "*.color = true" to
mean 'auto'.  Because git can internally use pager and has a way
for the user to control enabling/disabling colors when the pager
is used, there is no _logical_ reason to enable pager when the
output is not going to a tty.
    
Gaah, sorry; I meant "no logical reason to enable _color_ when
the output is not going to a tty".
Sure there is, when the output is "less -R"

Sam.

Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d)

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:43:32

Hi,

On Sat, 1 Sep 2007, Sam Vilain wrote:
Junio C Hamano wrote:
quoted
quoted
I was almost going to suggest us to change "*.color = true" to
mean 'auto'.  Because git can internally use pager and has a way
for the user to control enabling/disabling colors when the pager
is used, there is no _logical_ reason to enable pager when the
output is not going to a tty.
    
Gaah, sorry; I meant "no logical reason to enable _color_ when
the output is not going to a tty".
Sure there is, when the output is "less -R"
This argument was already raised by Junio himself.  But your _option_ to 
use "git log | less -R" does not make it a good option.  Since "git log" 
is so much more elegant already.

Hth,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help