[PATCH] builtin-push: New long option --verbose

Implemented and documented new option.

Signed-off-by: Jari Aalto <redacted>
---
 Documentation/git-push.txt |    4 ++--
 builtin-push.c             |    5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
index f8cc2b5..fb9dc7f 100644
--- a/Documentation/git-push.txt
+++ b/Documentation/git-push.txt

@@ -8,7 +8,7 @@ git-push - Update remote refs along with associated objects
 
 SYNOPSIS
 --------
-'git-push' [--all] [--tags] [--receive-pack=<git-receive-pack>] [--repo=all] [-f | --force] [-v] [<repository> <refspec>...]
+'git-push' [--all] [--tags] [--receive-pack=<git-receive-pack>] [--repo=all] [-f | --force] [-v | --verbose] [<repository> <refspec>...]
 
 DESCRIPTION
 -----------

@@ -91,7 +91,7 @@ the remote repository.
 	transfer spends extra cycles to minimize the number of
 	objects to be sent and meant to be used on slower connection.
 
--v::
+-v, \--verbose::
 	Run verbosely.
 
 include::urls.txt[]

diff --git a/builtin-push.c b/builtin-push.c
index cb78401..613f6c2 100644
--- a/builtin-push.c
+++ b/builtin-push.c

@@ -8,7 +8,7 @@
 
 #define MAX_URI (16)
 
-static const char push_usage[] = "git-push [--all] [--tags] [--receive-pack=<git-receive-pack>] [--repo=all] [-f | --force] [-v] [<repository> <refspec>...]";
+static const char push_usage[] = "git-push [--all] [--tags] [--receive-pack=<git-receive-pack>] [--repo=all] [-f | --force] [-v | --verbose] [<repository> <refspec>...]";
 
 static int all, tags, force, thin = 1, verbose;
 static const char *receivepack;

@@ -372,7 +372,8 @@ int cmd_push(int argc, const char **argv, const char *prefix)
 			i++;
 			break;
 		}
-		if (!strcmp(arg, "-v")) {
+		if (!strcmp(arg, "-v") ||
+                    !strcmp(arg, "--verbose")) {
 			verbose=1;
 			continue;
 		}

-- 
1.5.3.rc5

Hi,

On Mon, 27 Aug 2007, Jari Aalto wrote:

Implemented and documented new option.

It is not "new".  It is just a long form for the already existing "-v".

Ciao,
Dscho

Johannes Schindelin [off-list ref] writes:

Hi,

On Mon, 27 Aug 2007, Jari Aalto wrote:

quoted

Implemented and documented new option.

It is not "new".  It is just a long form for the already existing "-v".

Perception is in the eye. "new long option"
                               ===========

Jari

Hi,

[please, if you reply to my message, do not kill me from the address list]

On Mon, 27 Aug 2007, Jari Aalto wrote:

Johannes Schindelin [off-list ref] writes:

quoted

On Mon, 27 Aug 2007, Jari Aalto wrote:

quoted

Implemented and documented new option.

It is not "new".  It is just a long form for the already existing "-v".

Perception is in the eye. "new long option"
                               ===========

More appropriate: "Add long option --verbose".

Even as a long option, it is not new.  There have been plenty "--verbose"s 
in git before.

It might appear to you as a minor nit, but reading commit logs it is 
pretty disruptive to read about the "new" option and wondering "why the 
heck was it not there before?  Ah, it was.  The committer just added the 
long version of the option".

Ciao,
Dscho