[PATCH] git-p4: Fix sorting changelists when cloning a Perforce repository

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] git-p4: Fix sorting changelists when cloning a Perforce repository

From: Reece Dunn <hidden>
Date: 2016-06-15 22:43:29

Hi,

When performing a git-p4 clone operation on a Perforce repository,
where the changelists change in order of magnitude (e.g. 100 to 1000),
the set of changes to import from is not sorted properly. This is
because the data in the list is strings not integers. The other place
where this is done already converts the value to an integer, so it is
not affected.

This patch fixes this issue.

- Reece

Re: [PATCH] git-p4: Fix sorting changelists when cloning a Perforce repository

From: Simon Hausmann <hidden>
Date: 2016-06-15 22:43:29

On Monday 13 August 2007 20:50:59 Reece Dunn wrote:
Hi,

When performing a git-p4 clone operation on a Perforce repository,
where the changelists change in order of magnitude (e.g. 100 to 1000),
the set of changes to import from is not sorted properly. This is
because the data in the list is strings not integers. The other place
where this is done already converts the value to an integer, so it is
not affected.

This patch fixes this issue.
Acked-by: Simon Hausmann <redacted>


Thanks,
Simon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help