2 messages, 2 authors, 2016-06-15 · open the first message on its own page
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:28
I think your other patch to always give full path to the shell scripts from git-sh-setup makes sense. Could you please make test scripts to expose the problems you described in the message I am replying to and add it as say t/t2050-git-dir-relative.sh?
From: David Kastrup <hidden>
Date: 2016-06-15 22:43:28
Signed-off-by: David Kastrup <redacted> --- It takes an inordinarily large amount of time to create these tests, I am afraid. There is little sense in making a more extensive audit, cranking out more cases which fail with relative paths, when the fix, namely making GIT_DIR absolute, is so simple. t/t2050-git-dir-relative.sh | 54 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 54 insertions(+), 0 deletions(-) create mode 100755 t/t2050-git-dir-relative.sh
diff --git a/t/t2050-git-dir-relative.sh b/t/t2050-git-dir-relative.sh
new file mode 100755
index 0000000..54a3512
--- /dev/null
+++ b/t/t2050-git-dir-relative.sh@@ -0,0 +1,54 @@ +#!/bin/sh + +test_description='check problems with relative GIT_DIR + +This test creates a working tree state with a file and subdir: + + top (committed several times) + subdir (a subdirectory) + +It creates a commit-hook and tests it, then moves .git +into the subdir while keeping the worktree location, +and tries commits from the top and the subdir, checking +that the commit-hook still gets called.' + +. ./test-lib.sh + +test_expect_success 'Setting up post-commit hook' ' +mkdir -p .git/hooks && +cat <<EOF >.git/hooks/post-commit && +#!/bin/sh +touch $(pwd)/output +echo "Post commit hook was called." +EOF +chmod +x .git/hooks/post-commit' + +test_expect_success 'post-commit hook used ordinarily' ' +echo initial >top && +git-add top +git-commit -m initial && +test -r output +' + +rm -rf output +mkdir subdir +mv .git subdir + +test_expect_success 'post-commit-hook created and used from top dir' ' +echo changed >top && +git --git-dir subdir/.git add top && +git --git-dir subdir/.git commit -m topcommit && +test -r output +' + +rm -rf output + +test_expect_success 'post-commit-hook from sub dir' ' +echo changed again >top +cd subdir && +git --git-dir .git --work-tree .. add ../top && +git --git-dir .git --work-tree .. commit -m subcommit && +test -r ../output +' + +test_done
--
1.5.3.rc2.187.g9a1d2-dirty