Re: [PATCH] (Really) Fix install-doc-quick target

Johannes Schindelin [off-list ref] writes:

On Mon, 6 Aug 2007, Mark Levedahl wrote:

quoted

-	for i in `git ls-tree -r --name-only $head`
+	for i in `git --git-dir="$GIT_DIR" ls-tree -r --name-only $head`

This awfully looks like hiding a bug.  It should _never_ be necessary to 
say '--git-dir="$GIT_DIR"'.

Yes.  And 00d8c51 obviously "works for me", so there is
something different between what Mark and I are doing.  I cannot
tell what it is.

Junio C Hamano wrote:

Yes.  And 00d8c51 obviously "works for me", so there is
something different between what Mark and I are doing.  I cannot
tell what it is.
  

GZ=1 make quick-install-doc

...fails because git-ls-tree is called when cwd=$mandir which is nowhere 
under or related to $GIT_DIR.

Mark

Hi,

On Mon, 6 Aug 2007, Mark Levedahl wrote:

Junio C Hamano wrote:

quoted

Yes.  And 00d8c51 obviously "works for me", so there is
something different between what Mark and I are doing.  I cannot
tell what it is.
  

GZ=1 make quick-install-doc

...fails because git-ls-tree is called when cwd=$mandir which is nowhere under
or related to $GIT_DIR.

Ah, I suspect you do not have the latest 'master' installed?

Ciao,
Dscho

Johannes Schindelin wrote:

Ah, I suspect you do not have the latest 'master' installed?

Ciao,
Dscho

  

git>git fetch origin
git>git show-ref origin/master
a76c2acb28146f5630592f2ba738c0ebf0f3c1c4 refs/remotes/origin/master
git>git checkout -b test origin/master
Branch test set up to track remote branch refs/remotes/origin/master.
Switched to a new branch "test"
git>GZ=1 make prefix=/usr quick-install-doc
GIT_VERSION = 1.5.3.rc4.16.ga76c2
make -C Documentation quick-install
make[1]: Entering directory `/usr/src/git/Documentation'
rm -f doc.dep+ doc.dep
perl ./build-docdep.perl >doc.dep+
mv doc.dep+ doc.dep
make -C ../ GIT-VERSION-FILE
make[2]: Entering directory `/usr/src/git'
make[2]: `GIT-VERSION-FILE' is up to date.
make[2]: Leaving directory `/usr/src/git'
make[1]: Leaving directory `/usr/src/git/Documentation'
make[1]: Entering directory `/usr/src/git/Documentation'
make -C ../ GIT-VERSION-FILE
make[2]: Entering directory `/usr/src/git'
make[2]: `GIT-VERSION-FILE' is up to date.
make[2]: Leaving directory `/usr/src/git'
sh ./install-doc-quick.sh origin/man /usr/share/man
fatal: Not a git repository
make[1]: Leaving directory `/usr/src/git/Documentation'
git>