Re: Bug in gitk search box

Paul Mackerras [off-list ref] writes:

It turns out that this problem crept in when I changed from using git
rev-list --header to git log -z --pretty=raw, and the thing that
causes it is that git rev-list puts a null character after every
commit, while git log only puts a null between commits, i.e., there
isn't a null after the last commit.

Junio, is this behaviour deliberate?

There was a recent message from Linus on the list, stating that
NUL in -z format is inter-record separator, not after-record
terminator.

Junio C Hamano writes:

There was a recent message from Linus on the list, stating that
NUL in -z format is inter-record separator, not after-record
terminator.

OK, I'll have to change gitk then.  It looks like both Marco and I got
tricked by this.  I suggest it's worth a mention in the documentation.

Paul.

On 7/26/07, Paul Mackerras [off-list ref] wrote:

OK, I'll have to change gitk then.  It looks like both Marco and I got
tricked by this.

Yes. With commit c1672ba272c8e of 22 of Jun I make qgit to always
append a '\0' at the end of the stream so to avoid to change parsing
function.

Marco