Re: [PATCH] Teach git-commit about commit message templates.

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] Teach git-commit about commit message templates.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:23

Steven Grimm [off-list ref] writes:
Junio C Hamano wrote:
...
quoted
I am more worried about how this should interact with cases
where you usually do not start the log message from scratch.
For example, are there cases / policies where being able to use
templates to leave comments on merge commits are needed?
Squash-commits?  Perhaps "apply this template but only when you
have hand resolved a conflicting merges"?
Those are all valid cases. They also happen to be ones that are not
personally useful to me; none of the stuff in my company's commit
template would really apply to merges. I'm happy to do it if you think
those cases need to be handled before this can go in, but given
there's at least one user out there who doesn't need those things, I
wonder if this makes more sense to hold off on until someone actually
asks for it.
...
Is your hunch about the common case different than mine? Again, I can
go address this if it'll actually be useful.
No, I am way more cunning and lazy than that.  I did not have
hunch about the common case, so I just had you (and anybody else
who would join the thread) do necessary thinking and guessing
for me ;-)

Re: [PATCH] Teach git-commit about commit message templates.

From: Steven Grimm <hidden>
Date: 2016-06-15 22:43:23

Junio C Hamano wrote:
No, I am way more cunning and lazy than that.  I did not have
hunch about the common case, so I just had you (and anybody else
who would join the thread) do necessary thinking and guessing
for me ;-)
  
Ah, good. So it sounds like what I've got is at least an okay first cut 
from a functionality point of view. Dscho (or anyone else), any 
objections to the code in v2 of my patch? I believe I addressed all the 
feedback from v1.

-Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help