Re: [PATCH] Fix translation of strings in foreach lists.

----- Original Message ----
From: Christian Stimming <redacted>
To: Shawn O. Pearce <redacted>
Cc: Brett Schwarz <redacted>; git@vger.kernel.org; Paul Mackerras <redacted>; Junio C Hamano <redacted>
Sent: Tuesday, July 24, 2007 8:20:28 AM
Subject: Re: [PATCH] Fix translation of strings in foreach lists.

Quoting "Shawn O. Pearce" [off-list ref]:

quoted

quoted

quoted

I not sure if it's worth changing, but you don't necessarily need
those [append]'s in there.

Thanks for the info. It is basically up to Shawn to decide which style
he likes more.

"[mc Foo]\n\n$err"

is much shorter.  So I'd prefer that over [append [mc Foo] "\n\n$err"].

Err, but the usual case is that the argument to [mc] is more than one  
word, and (additionally) that argument has to be quoted by  
double-quotes (as opposed to braces) because otherwise xgettext  
doesn't extract the message correctly. Hence, the only possibility  
here were

   "[mc "Some Text"]\n\n$err"

Is this valid Tcl? Being a newcomer to this language I have to says  
the quotes here look rather strange :-)

Yes, that's valid.

bschwarz@bschwarz-desktop:~/gittcl$ tclsh
% package require msgcat
1.3.4
% namespace import msgcat::mc
% set err "ERROR"
ERROR
% msgcat::mcset en "hello there" HOWDY
HOWDY
% puts "[mc "hello there"]\n\n$err"
HOWDY

ERROR
%


HTH,
    --brett




       
____________________________________________________________________________________
Looking for a deal? Find great prices on flights and hotels with Yahoo! FareChase.
http://farechase.yahoo.com/