From: Peter Oberndorfer <hidden> Date: 2016-06-15 22:43:23
Hi,
the initial reason for this patches is that here on my system qgit4 looks like this
http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png
which is a bit suboptimal for viewing patches :-)
this is on a standard qt 4.3 from gentoo
While i was there i removed the same problem in the custom action editor
and removed some unneed empty space
Actually locally i removed even more empty space, like around the main tab view
and inside the main tab view.
If anyone wants me to remove that too, i would be happy to send more patches
[QGIT4 PATCH 1/6] update patchview.ui with new qt designer
When i edit the .ui files with the QT designer it updates some unrelated parts.
Because of this i split the update into a separate patch so the real changes are obvious.
Feel free to collapse them if you want
[QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding
this fixes the problem from the screenshot above
[QGIT4 PATCH 3/6] update patchview.ui with new qt designer
same reason as patch 1
[QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox
fix same problem in custom action editor
[QGIT4 PATCH 5/6] remove empty space below "diff to" header in patch view
[QGIT4 PATCH 6/6] remove empty space below button bar in file view
these remove some more empty space which i personally find useless
Apply if you like them
If you want i can provide more screenshots of how patches change appearance.
Greetings Peter
From: Peter Oberndorfer <hidden> Date: 2016-06-15 22:43:23
else the diff to header will take up half of the vertical space
Signed-off-by: Peter Oberndorfer <redacted>
---
src/patchview.ui | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
From: Peter Oberndorfer <hidden> Date: 2016-06-15 22:43:23
in action setup dialog to expanding
else the empty space with the button below takes up half of the vertical space
Signed-off-by: Peter Oberndorfer <redacted>
---
src/customaction.ui | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
From: Peter Oberndorfer <hidden> Date: 2016-06-15 22:43:23
On Monday 23 July 2007 22:32, Peter Oberndorfer wrote:
Hi,
the initial reason for this patches is that here on my system qgit4 looks like this
http://img77.imageshack.us/my.php?image=qgit4strangewindowgi0.png
which is a bit suboptimal for viewing patches :-)
this is on a standard qt 4.3 from gentoo
While i was there i removed the same problem in the custom action editor
and removed some unneed empty space
Actually locally i removed even more empty space, like around the main tab view
and inside the main tab view.
If anyone wants me to remove that too, i would be happy to send more patches
[QGIT4 PATCH 1/6] update patchview.ui with new qt designer
When i edit the .ui files with the QT designer it updates some unrelated parts.
Because of this i split the update into a separate patch so the real changes are obvious.
Feel free to collapse them if you want
[QGIT4 PATCH 2/6] change size policy of the patch viewer to expanding
this fixes the problem from the screenshot above
[QGIT4 PATCH 3/6] update patchview.ui with new qt designer
same reason as patch 1
[QGIT4 PATCH 4/6] change size policy of splitter which contains the list and the textbox
fix same problem in custom action editor
[QGIT4 PATCH 5/6] remove empty space below "diff to" header in patch view
[QGIT4 PATCH 6/6] remove empty space below button bar in file view
these remove some more empty space which i personally find useless
Apply if you like them
If you want i can provide more screenshots of how patches change appearance.
Greetings Peter
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
hmm, kmail moved Signed-off-by in patches to mail headers,
because there was no message text before it.
so here is a
Signed-off-by: Peter Oberndorfer <redacted>
for all my qgit patches
Greetings Peter
Hi Peter,
OMG that's horrific! I can't understand how it is possible, on my box
(Mandriva with QT4.3) everything is fine.
Anyway thanks a lot for the patches. Already applied and pushed.
> If anyone wants me to remove that too, i would be happy to send more patches
Please feel free to send me any patch that could improve the GUI,
unfortunately on my box I'm unable to see all these defects, so any
patch from you is more then welcome.
If you want i can provide more screenshots of how patches change appearance.
Patchview has not changed for me with your patches, fileview yes, I
can see the difference and also customaction. I would say nice job!
thanks.
Marco
Hi Peter,
OMG that's horrific! I can't understand how it is possible, on my box
(Mandriva with QT4.3) everything is fine.
Anyway thanks a lot for the patches. Already applied and pushed.
Thanks for applying.
> If anyone wants me to remove that too, i would be happy to send more patches
Please feel free to send me any patch that could improve the GUI,
unfortunately on my box I'm unable to see all these defects, so any
patch from you is more then welcome.
Will send them when they are cleaned up properly.
quoted
If you want i can provide more screenshots of how patches change appearance.
Patchview has not changed for me with your patches, fileview yes, I
can see the difference and also customaction. I would say nice job!
thanks.
Marco
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html