From: Junio C Hamano <hidden> Date: 2016-06-15 22:43:21
Greg KH [off-list ref] writes:
When using git-send-email.perl on a changeset that has:
Cc: [off-list ref]
in the body of the description, and the Email::Valid perl module is
installed on the system, the email address will be deemed "invalid" for
some reason (Email::Valid isn't smart enough to handle this?) and
complain and not send the address the email.
That appears to be the case.
bad foo
bad [off-list ref]
ok foo@bar.baz
ok Foo [off-list ref]
Anyway, this tiny patch fixes this problem for me. Note, my perl-foo is
quite week, so this could probably be easily done in one line for those
with better reg-ex skills.
@@ -410,6 +410,9 @@ sub extract_valid_address {return$addressif($address=~ /^($local_part_regexp)$/);if($have_email_valid){+if($address=~s/^<//){+$address=~s/>$//;+}returnscalarEmail::Valid->address($address);}else{
I'd probably do:
if ($have_email_valid) {
$address =~ s/^<(.*)>$/$1/;
return scalar Email::Valid->address($address);
} else {
instead, but they are moral equivalents.
Thanks for a fix.
On Thu, Jul 12, 2007 at 10:47:17PM -0700, Junio C Hamano wrote:
Greg KH [off-list ref] writes:
quoted
When using git-send-email.perl on a changeset that has:
Cc: [off-list ref]
in the body of the description, and the Email::Valid perl module is
installed on the system, the email address will be deemed "invalid" for
some reason (Email::Valid isn't smart enough to handle this?) and
complain and not send the address the email.
That appears to be the case.
bad foo
bad [off-list ref]
ok foo@bar.baz
ok Foo [off-list ref]
quoted
Anyway, this tiny patch fixes this problem for me. Note, my perl-foo is
quite week, so this could probably be easily done in one line for those
with better reg-ex skills.
On Thu, Jul 12, 2007 at 10:47:17PM -0700, Junio C Hamano wrote:
quoted
Greg KH [off-list ref] writes:
quoted
When using git-send-email.perl on a changeset that has:
Cc: [off-list ref]
in the body of the description, and the Email::Valid perl module is
installed on the system, the email address will be deemed "invalid" for
some reason (Email::Valid isn't smart enough to handle this?) and
complain and not send the address the email.
That appears to be the case.
bad foo
bad [off-list ref]
ok foo@bar.baz
ok Foo [off-list ref]
This would be a bug in Email::Valid as it complains that the second
address fails the rfc822 check, however rfc822 says that the "display
name" before the '<' is optional.
quoted
I'd probably do:
if ($have_email_valid) {
$address =~ s/^<(.*)>$/$1/;
On Thu, Jul 12, 2007 at 10:47:17PM -0700, Junio C Hamano wrote:
quoted
Greg KH [off-list ref] writes:
quoted
When using git-send-email.perl on a changeset that has:
Cc: [off-list ref]
in the body of the description, and the Email::Valid perl module is
installed on the system, the email address will be deemed "invalid" for
some reason (Email::Valid isn't smart enough to handle this?) and
complain and not send the address the email.
That appears to be the case.
bad foo
bad [off-list ref]
ok foo@bar.baz
ok Foo [off-list ref]
This would be a bug in Email::Valid as it complains that the second
address fails the rfc822 check, however rfc822 says that the "display
name" before the '<' is optional.
I agree, do you know how to get such a fix made?
thanks,
greg k-h
On Fri, Jul 13, 2007 at 06:28:18PM +1000, Stephen Rothwell wrote:
quoted
This would be a bug in Email::Valid as it complains that the second
address fails the rfc822 check, however rfc822 says that the "display
name" before the '<' is optional.
I agree, do you know how to get such a fix made?
I would be inclined to make it my distribution's problem :-) i.e. on
Debian I would report a bug against libemail-valid-perl.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/