Re: [PATCH] git-send-email: Add --threaded option

Adam Roben [off-list ref] writes:

The --threaded option controls whether the In-Reply-To header will be set on
any emails sent. The current behavior is to always set this header, so this
option is most useful in its negated form, --no-threaded. This behavior can
also be controlled through the 'sendemail.threaded' config setting.

Signed-off-by: Adam Roben <redacted>

Thanks.  I've always felt that send-email has too much built-in
policy; I think this is a sensible change.

While we are at it, you might want to make everything other than
quiet and dry_run overridable the same way.

On Jun 26, 2007, at 10:21 PM, Junio C Hamano wrote:

Adam Roben [off-list ref] writes:

quoted

@@ -138,8 +141,8 @@ my (@to,@cc,@initial_cc,@bcclist,@xh,

	$initial_reply_to,$initial_subject,@files,$from,$compose,$time);

# Behavior modification variables
-my ($chain_reply_to, $quiet, $suppress_from, $no_signed_off_cc,
-	$dry_run) = (1, 0, 0, 0, 0);
+my ($threaded, $chain_reply_to, $quiet, $suppress_from,  
$no_signed_off_cc,
+	$dry_run) = (1, 1, 0, 0, 0, 0);

While we are at it, you might want to make everything other than
quiet and dry_run overridable the same way.

    --[no-]chain-reply-to, --suppress-from and --no-signed-off-cc  
already exist, so do you mean that we should support --no-suppress- 
from and --signed-off-cc (i.e., the negations) as well? Or that we  
should have equivalent config settings for these? Or both?

    I also realized after sending this that git-format-patch has a -- 
[no-]thread option, so I think I'll change the name of this option to  
match.

-Adam