Re: [PATCH] t9500: skip gitweb tests if perl version is too old

Sven Verdoolaege [off-list ref] writes:

On Fri, Jun 22, 2007 at 11:31:40PM -0700, Junio C Hamano wrote:

quoted

Sven Verdoolaege [off-list ref] writes:

quoted

+perl -MEncode -e 'decode_utf8("", Encode::FB_CROAK)' >/dev/null 2>&1 || {
+    test_expect_success 'skipping gitweb tests, perl version is too old' :
+    test_done
+    exit
+}
+

Hmph.  Even something silly like:

	perl -MEncode -e 'decode_utf8("", Encode::FB_CLUCK)'

seem to succeed for me with 5.8.8.

Maybe I'm missing something, but it's supposed to succeed
for perl versions that are recent enough.

Well, "Encode::FB_CLUCK" is a bogus symbol even in recent Perl.
IOW, the tested function does not seem to care if I give
whatever garbage as the second parameter.

But I guess you are only interested if the perl used to run
gitweb barfs with that two parameter, so the original check
would be the right way.

Will apply, but I am about to go to bed, so it will be
tomorrow.

Thanks.

On Sat, Jun 23, 2007 at 03:14:08AM -0700, Junio C Hamano wrote:

Well, "Encode::FB_CLUCK" is a bogus symbol even in recent Perl.
IOW, the tested function does not seem to care if I give
whatever garbage as the second parameter.

But I guess you are only interested if the perl used to run
gitweb barfs with that two parameter, so the original check
would be the right way.

Indeed.  gitweb doesn't use FB_CLUCK and if it did, we would
want to know about it (and not skip the tests).

skimo