"Shawn O. Pearce" [off-list ref] writes:
Junio C Hamano [off-list ref] wrote:
quoted
This is only minor nuisance, but can we do something about this?
$ git gui --version
Application initialization failed: no display name and no $DISPLAY environment variable
I know it is from wish, not you, so I wouldn't insist, though.
Actually that should be fixable.
Should be as simple as using a Bourne shell script up front to
check for "z$1" = zversion || "z$1" = z--version, and if so dump
back the version, otherwise exec wish. This is actually quite easy
and won't change things for existing users. I'll put a patch into
maint tonight for it.
If this makes life any harder to people on Windows, especially
minGW, I would suggest against it.
Junio C Hamano [off-list ref] wrote:
"Shawn O. Pearce" [off-list ref] writes:
quoted
Junio C Hamano [off-list ref] wrote:
quoted
This is only minor nuisance, but can we do something about this?
$ git gui --version
Application initialization failed: no display name and no $DISPLAY environment variable
I know it is from wish, not you, so I wouldn't insist, though.
If this makes life any harder to people on Windows, especially
minGW, I would suggest against it.
Its already done. I don't think it will make a difference either
way right now.
Currently we still have to have a Bourne shell on both Cygwin
and MINGW platforms to perform key actions, like say git-clone.
The startup cost of git-gui is also rather high there anyway, so
this extra if test in Bourne shell before we exec into Tcl isn't
going to kill us.
Besides, you can side-step the entire Bourne shell thing by just
starting git-gui in wish yourself. E.g.
CALL /path/to/wish.exe /path/to/git-gui -- ...
I'd like to come back and make git-gui easier to install, perhaps by
making "starpacks" of git-gui and Git plumbing available for some
popular systems (e.g. MINGW/Windows, Mac OS X). Such starpacks
would give users an easy way to get git-gui (and thus basic Git)
up and running quickly. At that point I will need to revisit this
bootstrap code anyway.
--
Shawn.
Junio C Hamano wrote:
"Shawn O. Pearce" [off-list ref] writes:
quoted
Junio C Hamano [off-list ref] wrote:
quoted
This is only minor nuisance, but can we do something about this?
$ git gui --version
Application initialization failed: no display name and no $DISPLAY environment variable
I know it is from wish, not you, so I wouldn't insist, though.
Actually that should be fixable.
Should be as simple as using a Bourne shell script up front to
check for "z$1" = zversion || "z$1" = z--version, and if so dump
back the version, otherwise exec wish. This is actually quite easy
and won't change things for existing users. I'll put a patch into
maint tonight for it.
If this makes life any harder to people on Windows, especially
minGW, I would suggest against it.
The MinGW port's exec wrapper looks at the shbang line and runs the
shell. Hence, invocation as
git gui --version
will work even from CMD.EXE. But
git-gui --version
will only work from MSYS's rxvt.
-- Hannes