git-send-email (Fw: Delivery reports about your email [FAILED(1)])

Looks like at least some mailers don't like the Message-Id's
being spit out by the version of git-send-email this person
is using.

Just FYI from your friendly vger postmaster. :-)

RFC 2822 section 3.6.4 suggests that a "good method" for generating a
Message-ID is to put the domain name of the host on the right-side of
the "@" character.  Use Perl's Sys::Hostname to do the heavy lifting.
This module has been in the Perl core since version 5.
---
 git-send-email.perl |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index 7c0c90b..2259f4b 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl

@@ -21,6 +21,7 @@ use warnings;
 use Term::ReadLine;
 use Getopt::Long;
 use Data::Dumper;
+use Sys::Hostname;
 use Git;
 
 package FakeTerm;

@@ -411,9 +412,9 @@ sub extract_valid_address {
 # a random number to the end, in case we are called quicker than
 # 1 second since the last time we were called.
 
-# We'll setup a template for the message id, using the "from" address:
-my $message_id_from = extract_valid_address($from);
-my $message_id_template = "<%s-git-send-email-$message_id_from>";
+# We'll setup a template for the message id, using the hostname:
+my $hostname = hostname();
+my $message_id_template = "<%s-git-send-email\@$hostname>";
 
 sub make_message_id
 {

-- 
1.5.2.2.238.g7cbf2f2

On Wed, Jun 20, 2007 at 3:42 AM, David Miller [off-list ref] wrote:

Looks like at least some mailers don't like the Message-Id's
being spit out by the version of git-send-email this person
is using.

I'm going to guess the problem is the lack of a "@" in the Message-Id:

Message-Id: <11823357623688-git-send-email->

That's not really right. :)

Just FYI from your friendly vger postmaster. :-)

thanks.

-- 
Ryan