[PATCH] $EMAIL is a last resort fallback, as it's system-wide.

Subsystems: the rest

DORMANTno replies

2 messages, 1 author, 2016-06-15 · open the first message on its own page

[PATCH] $EMAIL is a last resort fallback, as it's system-wide.

From: Pierre Habouzit <hidden>
Date: 2016-06-15 22:43:14

From: Pierre Habouzit <redacted>

  Rationale: $EMAIL is a system-wide setup that is used for many many many
applications. If the git user chose a specific user.email setup, then _this_
should be honoured rather than $EMAIL.

Signed-off-by: Pierre Habouzit <redacted>
---
 ident.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ident.c b/ident.c
index 69a04b8..3d49608 100644
--- a/ident.c
+++ b/ident.c
@@ -196,9 +196,9 @@ const char *fmt_ident(const char *name, const char *email,
 	if (!name)
 		name = git_default_name;
 	if (!email)
-		email = getenv("EMAIL");
-	if (!email)
 		email = git_default_email;
+	if (!email)
+		email = getenv("EMAIL");
 
 	if (!*name) {
 		struct passwd *pw;
-- 
1.5.2.1

Re: [PATCH] $EMAIL is a last resort fallback, as it's system-wide.

From: Pierre Habouzit <hidden>
Date: 2016-06-15 22:43:14

  Eeeew sorry for the repost, I sent the bad patch with git send-email.
my mistake.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help