Re: [PATCH] gitweb: use decode_utf8 directly

Ismail Dönmez [off-list ref] writes:

On Friday 01 June 2007 22:44:36 Junio C Hamano wrote:

quoted

Alexandre Julliard [off-list ref] writes:

quoted

Sorry for the late nack, but it turns out that this patch breaks diff
output on the Wine server for files that are not utf-8.

The cause is apparently that decode_utf8() returns undef for invalid
sequences instead of substituting a replacement char like
decode("utf8") does.

Thanks for noticing.  Will revert.

Why are reverting a correct bugfix? :( He's at most using outdated software. 
*sigh*

I would assume that on top of a revert, with an additional

	return $str if is_utf8($str);

to to_utf8() you should be able to fix both installations that
has old or new Encode.pm?

On Friday 01 June 2007 23:00:31 you wrote:

Ismail Dönmez [off-list ref] writes:

quoted

On Friday 01 June 2007 22:44:36 Junio C Hamano wrote:

quoted

Alexandre Julliard [off-list ref] writes:

quoted

Sorry for the late nack, but it turns out that this patch breaks diff
output on the Wine server for files that are not utf-8.

The cause is apparently that decode_utf8() returns undef for invalid
sequences instead of substituting a replacement char like
decode("utf8") does.

Thanks for noticing.  Will revert.

Why are reverting a correct bugfix? :( He's at most using outdated
software. *sigh*

I would assume that on top of a revert, with an additional

	return $str if is_utf8($str);

to to_utf8() you should be able to fix both installations that
has old or new Encode.pm?

I can try the patch if you can send me what you propose. 

/ismail

-- 
Perfect is the enemy of good