Re: [PATCH] diff-delta: use realloc instead of xrealloc

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] diff-delta: use realloc instead of xrealloc

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:13

Martin Koegler [off-list ref] writes:
Commit 83572c1a914d3f7a8dd66d954c11bbc665b7b923 changed many
realloc to xrealloc. This change was made in diff-delta.c too,
although the code can handle an out of memory failure.

This patch reverts this change in diff-delta.c.
Wasn't there a discussion around this exact issue when the
original patch was applied?

Re: [PATCH] diff-delta: use realloc instead of xrealloc

From: Nicolas Pitre <hidden>
Date: 2016-06-15 22:43:13

On Tue, 29 May 2007, Junio C Hamano wrote:
Martin Koegler [off-list ref] writes:
quoted
Commit 83572c1a914d3f7a8dd66d954c11bbc665b7b923 changed many
realloc to xrealloc. This change was made in diff-delta.c too,
although the code can handle an out of memory failure.

This patch reverts this change in diff-delta.c.
Wasn't there a discussion around this exact issue when the
original patch was applied?
Maybe, but I cannot remember it, not can I justify that xrealloc now.


Nicolas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help